test(e2e): Major refactor and stabilization of e2e tests #7581
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7581 +/- ##
==========================================
- Coverage 57.15% 56.84% -0.31%
==========================================
Files 674 674
Lines 27276 27283 +7
Branches 2668 2669 +1
==========================================
- Hits 15589 15509 -80
- Misses 11347 11435 +88
+ Partials 340 339 -1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| 1. Use [user-facing locators](https://playwright.dev/docs/best-practices#use-locators) (Now a eslint rule!) | ||
|
|
||
| ```js | ||
| page.getByRole('button', { name: 'Create' } ) | ||
| ``` | ||
| Instead of | ||
| ```js | ||
| page.locator('.c-create-button') | ||
| ``` | ||
| Note: `page.locator()` can be used in performance tests as xk6-browser does not yet support the new `page.getBy` pattern and css lookups can be [1.5x faster](https://serpapi.com/blog/css-selectors-faster-than-getbyrole-playwright/) |
There was a problem hiding this comment.
suggestion:
- Prefer using user-facing locators for better readability and maintainability:
// Recommended
page.getByRole('button', { name: 'Create' })Instead of the less intuitive:
// Not recommended
page.locator('.c-create-button')Note: In performance tests, page.locator() may still be used as xk6-browser lacks support for the page.getBy pattern. Additionally, CSS selectors can be up to 1.5x faster than role-based selectors.
| @@ -152,7 +152,7 @@ test.describe('ExportAsJSON Disabled Actions', () => { | |||
| test.describe('ExportAsJSON ProgressBar @couchdb', () => { | |||
| let folder; | |||
| test.beforeEach(async ({ page }) => { | |||
| await page.goto('./', { waitUntil: 'networkidle' }); | |||
| await page.goto('./', { waitUntil: 'domcontentloaded' }); | |||
There was a problem hiding this comment.
i worry about this breaking the couchdb tests
e2e/tests/functional/plugins/imagery/exampleImagery.e2e.spec.js
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| await page.getByLabel('Edit Object').click(); | ||
|
|
||
| // Expand the 'My Items' folder in the left tree | ||
| page.click('button[title="Show selected item in tree"]'); |
| @@ -281,29 +281,3 @@ test.describe('Global Time Conductor', () => { | |||
| // select an option and verify the offsets are updated correctly | |||
| }); | |||
| }); | |||
|
|
|||
| test.describe('Time Conductor History', () => { | |||
There was a problem hiding this comment.
Is this totally gone?
There was a problem hiding this comment.
it's no longer relevant because you can't set milliseconds in the time conductor anymore. The time conductor history menu is still there, though. Maybe we should keep the suite
|
|
||
| return `${this.expanded ? 'Collapse' : 'Expand'}${name}${type}`; | ||
| return `${this.expanded ? 'Collapse' : 'Expand'}${name} Plot Series Options`; |
ozyx
changed the title
ozyx
changed the title
|
This PR touches runtime code and needs test instructions in the associated issue(s) |
Closes #7307
Closes #7797
Closes #7763
Describe your changes:
eslint-playwright-pluginpackage to v1.5.2@clocktests to use the clock API.page.click()to useLocator.click()insteadpage.dragAndDrop()to useLocator.dragTo(Locator)insteadAll Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist