-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Re-enable package lock #7584
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7584 +/- ##
==========================================
- Coverage 56.20% 56.15% -0.05%
==========================================
Files 672 672
Lines 27112 27112
Branches 2635 2635
==========================================
- Hits 15237 15224 -13
- Misses 11550 11563 +13
Partials 325 325
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Huzzah! |
.circleci/config.yml
Outdated
@@ -8,15 +8,15 @@ executors: | |||
- image: mcr.microsoft.com/playwright:v1.39.0-focal | |||
environment: | |||
NODE_ENV: development # Needed to ensure 'dist' folder created and devDependencies installed | |||
PERCY_POSTINSTALL_BROWSER: 'true' # Needed to store the percy browser in cache deps | |||
PERCY_LOGLEVEL: 'debug' # Enable DEBUG level logging for Percy (Issue: https://github.com/nasa/openmct/issues/5742) | |||
PERCY_POSTINSTALL_BROWSER: "true" # Needed to store the percy browser in cache deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Closes #1291
Describe your changes:
npm run clean
npm ci
instead ofnpm install
npm ci
instead ofnpm install
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist