Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Re-enable package lock #7584

Merged
merged 9 commits into from
Mar 14, 2024
Merged

[build] Re-enable package lock #7584

merged 9 commits into from
Mar 14, 2024

Conversation

unlikelyzero
Copy link
Collaborator

@unlikelyzero unlikelyzero commented Mar 12, 2024

Closes #1291

Describe your changes:

  • Enable package lock
  • Remove package-lock deletion from npm run clean
  • Update CircleCI to use npm ci instead of npm install
  • Update github Actions to use npm ci instead of npm install

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Mar 12, 2024
@unlikelyzero unlikelyzero requested review from akhenry and ozyx March 12, 2024 22:07
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.15%. Comparing base (10eb749) to head (de9c340).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7584      +/-   ##
==========================================
- Coverage   56.20%   56.15%   -0.05%     
==========================================
  Files         672      672              
  Lines       27112    27112              
  Branches     2635     2635              
==========================================
- Hits        15237    15224      -13     
- Misses      11550    11563      +13     
  Partials      325      325              
Flag Coverage Δ
e2e-full 23.60% <ø> (ø)
e2e-stable 59.91% <ø> (-0.09%) ⬇️
unit 49.12% <ø> (-0.02%) ⬇️
Files Coverage Δ
src/selection/Selection.js 76.05% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10eb749...de9c340. Read the comment docs.

@ozyx
Copy link
Contributor

ozyx commented Mar 12, 2024

Huzzah!

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Mar 12, 2024
@@ -8,15 +8,15 @@ executors:
- image: mcr.microsoft.com/playwright:v1.39.0-focal
environment:
NODE_ENV: development # Needed to ensure 'dist' folder created and devDependencies installed
PERCY_POSTINSTALL_BROWSER: 'true' # Needed to store the percy browser in cache deps
PERCY_LOGLEVEL: 'debug' # Enable DEBUG level logging for Percy (Issue: https://github.com/nasa/openmct/issues/5742)
PERCY_POSTINSTALL_BROWSER: "true" # Needed to store the percy browser in cache deps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh

Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 14, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 14, 2024
@akhenry akhenry enabled auto-merge (squash) March 14, 2024 16:15
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 14, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 14, 2024
@akhenry akhenry merged commit ceeb761 into master Mar 14, 2024
21 checks passed
@akhenry akhenry deleted the package-lock branch March 14, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] start using package.lock
3 participants