Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move file to correct folder #7652

Merged
merged 1 commit into from
Mar 29, 2024
Merged

fix: move file to correct folder #7652

merged 1 commit into from
Mar 29, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Mar 29, 2024

Closes #7653

Describe your changes:

The .npmignore for the openmct-e2e subpackage was included in a different folder by accident when I was experimenting with a different folder structure for the recent import/export fixes. This fixes the mistake.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Mar 29, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Mar 29, 2024
@ozyx ozyx requested review from akhenry and unlikelyzero March 29, 2024 00:22
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (a3fb84a) to head (d3b17b8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7652      +/-   ##
==========================================
+ Coverage   49.09%   49.11%   +0.02%     
==========================================
  Files         671      671              
  Lines       27114    27114              
  Branches     2632     2632              
==========================================
+ Hits        13312    13318       +6     
+ Misses      13474    13468       -6     
  Partials      328      328              
Flag Coverage Δ
unit 49.11% <ø> (+0.02%) ⬆️

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3fb84a...d3b17b8. Read the comment docs.

@akhenry akhenry merged commit f98eb31 into master Mar 29, 2024
43 of 56 checks passed
@akhenry akhenry deleted the fix-the-oopsie branch March 29, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.npmignore for the openmct-e2e subpackage is not in the correct folder
3 participants