Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darkmatter] Create new darkmatter theme #7682

Merged
merged 45 commits into from
Apr 25, 2024
Merged

[Darkmatter] Create new darkmatter theme #7682

merged 45 commits into from
Apr 25, 2024

Conversation

rukmini-bose
Copy link
Contributor

@rukmini-bose rukmini-bose commented Apr 10, 2024 •
edited by ozyx
Loading

Closes #7681

Describe your changes:

  • Create new theme plugin for darkmatter
  • Create new .scss file with initial stylistic changes. More changes to come in a separate PR

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

rukmini-bose and others added 26 commits March 26, 2024 10:36
@rukmini-bose
initial theme plugin setup, changes to layout frames
bc4ad98
@unlikelyzero @rukmini-bose
update visual tests
335a29c
@rukmini-bose
Changes to gauge, layout borders, and background
bb11d6d
@rukmini-bose
Make background image a DIY theme variable. Fixes made to gauges. Del…
df587ca 
…eted custom font.
@rukmini-bose
More changes to overall background colors. Added glass layer effect t…
89d33ef 
…o menus
@rukmini-bose
changes to menu
ac07a88
@rukmini-bose
Fix to make theme easy to run
11762bd
@rukmini-bose
Fix tab colors and add glass background to menus
081da4c
@rukmini-bose
make highlightd corners longer
f35e721
@rukmini-bose
Initial changes to font styles
d1bc48c
@rukmini-bose
Add temporary numeric font style. Test numeric font in gauges.
4abdffc
@rukmini-bose
Initial changes to alphanumerics in layouts
9e9857e
@rukmini-bose
Updated variables
270e3e7
@rukmini-bose
update plugin.js file
39cf1ca
@rukmini-bose
Fix highlighted corners on frames such that it uses outermost frame
7a1e8ef
@rukmini-bose
renaming theme plugin and rename branch
cbe857f
@rukmini-bose
fix button colors to be more readable
3a917da
@rukmini-bose
change background image
6913ea4
@rukmini-bose
Merge branch 'master' into darkmatter-theme
d52470b
@rukmini-bose
Fix bad merges from other theme files. Fix gauge and alphanumerics su…
fcbff2d 
…ch that they dont have darkmatter borders
@rukmini-bose
more fixes
83bba7d
@rukmini-bose
Fix where mixin is used such that when an object's frame is hidden, h…
0b6de22 
…ighlgihts disappear
@rukmini-bose
remove blur from meter gauges
6a8328f
@rukmini-bose
Merge branch 'master' into darkmatter-theme
524726f
@rukmini-bose
Add comment about this theme being in beta mode
fe4d3b0
@rukmini-bose
Delete draft .scss file that is no longer needed
38cd0ba
@rukmini-bose rukmini-bose requested a review from ozyx April 10, 2024 21:07
@rukmini-bose rukmini-bose marked this pull request as ready for review April 10, 2024 21:08
@rukmini-bose rukmini-bose requested a review from charlesh88 April 11, 2024 17:39
@unlikelyzero unlikelyzero added pr:e2e:couchdb npm run test:e2e:couchdb pr:e2e:perf Trigger perf tests labels Apr 17, 2024
@github-actions github-actions bot removed pr:e2e:couchdb npm run test:e2e:couchdb pr:e2e:perf Trigger perf tests labels Apr 17, 2024
charlesh88
charlesh88 requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about _constants-darkmatter.scss, there are issues.

@rukmini-bose rukmini-bose requested a review from charlesh88 April 22, 2024 21:57
charlesh88
charlesh88 requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left specific line comments in _constants-darkmatter.scss.

More broadly, that file and the other theme files have been altered (maybe due to merge problems) and have had at least 3 mixins moved to the bottom of the file from the top.

At left, master; right, darkmatter-theme branch:

image

image

You need to open each theme file, and use a branch comparison view to compare your version with the version in master. You need to bring your versions back to the master versions, with the exception of the addition of new constants that are needed globally. Let me know if there are any questions.

src/styles/_constants-darkmatter.scss Outdated Show resolved Hide resolved
src/styles/_constants-darkmatter.scss Outdated Show resolved Hide resolved
src/styles/_constants-darkmatter.scss Show resolved Hide resolved
src/styles/_constants-darkmatter.scss Outdated Show resolved Hide resolved
src/styles/_constants-darkmatter.scss Outdated Show resolved Hide resolved
@rukmini-bose rukmini-bose requested a review from charlesh88 April 23, 2024 18:10
@ozyx ozyx modified the milestones: Target:4.0.0, Target:4.0.1 Apr 25, 2024
charlesh88
charlesh88 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rukmini-bose
Copy link
Contributor Author

Testing Instructions: #7681

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 25, 2024
ozyx
ozyx suggested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx enabled auto-merge (squash) April 25, 2024 17:38
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 25, 2024
ozyx
ozyx approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx merged commit b3d3465 into master Apr 25, 2024
24 of 28 checks passed
@ozyx ozyx deleted the darkmatter-theme branch April 25, 2024 23:06
@ozyx
Copy link
Contributor

ozyx commented Apr 25, 2024

LGTM

wowwwww

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozyx ozyx ozyx approved these changes

@charlesh88 charlesh88 charlesh88 approved these changes

Assignees
No one assigned
Labels
not_viper Temporary label to define bugs that won't affect viper deployments type:enhancement
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging this pull request may close these issues.

[Darkmatter] Add New Theme Plugin
5 participants
@rukmini-bose @codecov-commenter @ozyx @charlesh88 @unlikelyzero