Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the final .bounds() call #7695

Merged
merged 1 commit into from
Apr 17, 2024
Merged

refactor: remove the final .bounds() call #7695

merged 1 commit into from
Apr 17, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Apr 16, 2024

Closes #7687

Describe your changes:

Woops. Missed one.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added this to the Target:4.0.0 milestone Apr 16, 2024
@ozyx ozyx requested a review from unlikelyzero April 16, 2024 22:10
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.40%. Comparing base (ef8b353) to head (9de7b69).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7695      +/-   ##
==========================================
+ Coverage   55.76%   56.40%   +0.63%     
==========================================
  Files         672      672              
  Lines       27183    27183              
  Branches     2634     2634              
==========================================
+ Hits        15159    15332     +173     
+ Misses      11696    11523     -173     
  Partials      328      328              
Flag Coverage Δ
e2e-full 23.55% <0.00%> (ø)
e2e-stable 60.00% <100.00%> (+2.58%) ⬆️
unit 49.17% <100.00%> (-0.03%) ⬇️
Files Coverage Δ
src/api/time/IndependentTimeContext.js 81.29% <100.00%> (ø)

... and 32 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef8b353...9de7b69. Read the comment docs.

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Apr 16, 2024
@ozyx ozyx enabled auto-merge (squash) April 17, 2024 16:19
@ozyx ozyx merged commit 5a06b51 into master Apr 17, 2024
34 of 44 checks passed
@ozyx ozyx deleted the oops-missed-a-spot branch April 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all usage of deprecated Time API methods
3 participants