-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure time conductor mode is set when synchronizing time range #7731
Conversation
… the old bounds time API.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7731 +/- ##
==========================================
- Coverage 56.65% 56.64% -0.01%
==========================================
Files 673 673
Lines 27177 27177
Branches 2636 2636
==========================================
- Hits 15396 15395 -1
- Misses 11450 11451 +1
Partials 331 331
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@shefalijoshi we should add a test in the timeconductor suite |
Tests, please. Nothing should be pushed any more without tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you write a test?
…c-time-conductor-plots
I'll write a test in the plots suite since this is specific to a plots control |
Test updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@shefalijoshi , approved but looks like there are lint errors |
Closes #7729
Describe your changes:
Use setMode API to set the time span as well as the bounds instead of the old bounds time API.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist