Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure time conductor mode is set when synchronizing time range #7731

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented May 14, 2024

Closes #7729

Describe your changes:

Use setMode API to set the time span as well as the bounds instead of the old bounds time API.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@shefalijoshi shefalijoshi added this to the Target:4.0.1 milestone May 14, 2024
@shefalijoshi shefalijoshi requested a review from davetsay May 14, 2024 17:40
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.64%. Comparing base (c354e1c) to head (6bca2b0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7731      +/-   ##
==========================================
- Coverage   56.65%   56.64%   -0.01%     
==========================================
  Files         673      673              
  Lines       27177    27177              
  Branches     2636     2636              
==========================================
- Hits        15396    15395       -1     
- Misses      11450    11451       +1     
  Partials      331      331              
Flag Coverage Δ
e2e-full 23.57% <ø> (ø)
e2e-stable 60.63% <ø> (-0.01%) ⬇️
unit 49.25% <0.00%> (ø)
Files Coverage Δ
src/plugins/plot/MctPlot.vue 38.81% <0.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c354e1c...6bca2b0. Read the comment docs.

@unlikelyzero
Copy link
Collaborator

@shefalijoshi we should add a test in the timeconductor suite

@akhenry
Copy link
Contributor

akhenry commented May 21, 2024

Tests, please. Nothing should be pushed any more without tests.

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you write a test?

@shefalijoshi
Copy link
Contributor Author

@shefalijoshi we should add a test in the timeconductor suite

I'll write a test in the plots suite since this is specific to a plots control

@shefalijoshi shefalijoshi requested a review from davetsay May 22, 2024 22:09
@shefalijoshi
Copy link
Contributor Author

Test updated.

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davetsay davetsay added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels May 23, 2024
Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davetsay
Copy link
Contributor

@shefalijoshi , approved but looks like there are lint errors

@shefalijoshi shefalijoshi added pr:e2e Automatically triggers e2e tests to run pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e Automatically triggers e2e tests to run labels May 29, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label May 29, 2024
@shefalijoshi shefalijoshi enabled auto-merge (squash) May 29, 2024 22:19
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 3, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 3, 2024
@shefalijoshi shefalijoshi merged commit 6360bc4 into master Jun 3, 2024
21 checks passed
@shefalijoshi shefalijoshi deleted the fix-sync-time-conductor-plots branch June 3, 2024 16:17
@ozyx ozyx modified the milestones: Target:4.0.1, Target:4.0.0 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchronize time conductor feature for plots not working
6 participants