fix(#7670): Ensure objects unsubscribe from staleness when destroyed #7736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g staleness provider to use new time api, add test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7736 +/- ##
==========================================
- Coverage 57.00% 56.63% -0.38%
==========================================
Files 673 673
Lines 27178 27177 -1
Branches 2635 2636 +1
==========================================
- Hits 15493 15391 -102
- Misses 11356 11455 +99
- Partials 329 331 +2
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ozyx
reviewed
May 23, 2024
| this.#updateRealTime(this.#openmct.time.getMode()); | ||
| } | ||
|
|
||
| this.#realtimeCheck(); |
shefalijoshi
requested changes
May 23, 2024
shefalijoshi
approved these changes
May 23, 2024
ozyx
suggested changes
May 23, 2024
ozyx
approved these changes
May 29, 2024
Comment on lines
+39
to
+43
| // edit properties and enable staleness updates | ||
| await page.getByLabel('More actions').click(); | ||
| await page.getByLabel('Edit properties...').click(); | ||
| await page.getByLabel('Provide Staleness Updates', { exact: true }).click(); | ||
| await page.getByLabel('Save').click(); |
| @@ -59,7 +59,7 @@ export default class SinewaveLimitProvider extends EventEmitter { | |||
| subscribeToStaleness(domainObject, callback) { | |||
| const id = this.#getObjectKeyString(domainObject); | |||
|
|
|||
| this.#realtimeCheck(); | |||
| this.#realTimeCheck(); | |||
ozyx
changed the title
Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7670
Describe your changes:
Clearing any existing staleness subscriptions before showing a new object.
Adding a new test to make sure this doesn't regress.
Added new functionality tocreateDomainObjectWithDefaultsto be able to set toggles when creating test objects.Using new timeAPI methods in SWG Staleness provider.
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist