Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump playwright to version 1.45.0 #7762

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Jun 26, 2024

Describe your changes:

Upgrade playwright to v1.45.0

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Jun 26, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Jun 26, 2024
@ozyx ozyx requested a review from unlikelyzero June 26, 2024 18:49
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.63%. Comparing base (291c099) to head (6cdcd2e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7762      +/-   ##
==========================================
- Coverage   56.94%   56.63%   -0.31%     
==========================================
  Files         673      673              
  Lines       27177    27177              
  Branches     2636     2636              
==========================================
- Hits        15475    15393      -82     
- Misses      11371    11453      +82     
  Partials      331      331              
Flag Coverage Δ
e2e-full 23.57% <ø> (-18.47%) ⬇️
e2e-stable 60.62% <ø> (ø)
unit 49.25% <ø> (ø)

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291c099...6cdcd2e. Read the comment docs.

@ozyx ozyx marked this pull request as ready for review June 26, 2024 20:11
@ozyx ozyx mentioned this pull request Jul 1, 2024
16 tasks
@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jul 1, 2024

@ozyx
Copy link
Contributor Author

ozyx commented Jul 2, 2024

@ozyx we need to bump all 4 repos per https://github.com/nasa/openmct/tree/master/e2e#upgrading-playwright

done

@unlikelyzero unlikelyzero added pr:e2e Automatically triggers e2e tests to run pr:platform Runs tests against all supported platforms pr:e2e:couchdb npm run test:e2e:couchdb labels Jul 2, 2024
@github-actions github-actions bot removed pr:platform Runs tests against all supported platforms pr:e2e:couchdb npm run test:e2e:couchdb pr:e2e Automatically triggers e2e tests to run labels Jul 2, 2024
@ozyx ozyx force-pushed the bump-playwright-1.45.0 branch from 02c2e9a to c01c0ae Compare July 2, 2024 17:35
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 2, 2024
@ozyx ozyx enabled auto-merge (squash) July 2, 2024 17:36
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 2, 2024
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 2, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 2, 2024
@ozyx ozyx merged commit 0215a5b into master Jul 2, 2024
21 checks passed
@ozyx ozyx deleted the bump-playwright-1.45.0 branch July 2, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants