-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: better docs and types for the API #7796
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7796 +/- ##
==========================================
- Coverage 57.15% 56.83% -0.32%
==========================================
Files 674 674
Lines 27276 27283 +7
Branches 2668 2668
==========================================
- Hits 15589 15506 -83
- Misses 11347 11437 +90
Partials 340 340
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @ozyx! Had a few suggestions below. Also tested renderWhenVisible changes and they seemed to work nicely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Describe your changes:
DomainObject
,Identifier
,ObjectPath
, etc. available at the root level so they can be used easily in JSDocsEventEmitter
so thattsc
correctly generates types for classes that extend itScreen.Recording.2024-07-30.at.11.29.01.AM.mov
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist