[Telemetry API] Prevent Subscriptions with different options from overwriting each other #7930
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7930 +/- ##
==========================================
+ Coverage 57.43% 57.53% +0.09%
==========================================
Files 677 677
Lines 27375 27404 +29
Branches 2690 2690
==========================================
+ Hits 15724 15766 +42
+ Misses 11310 11297 -13
Partials 341 341
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…or, more robust hash function
e2e/tests/functional/plugins/displayLayout/displayLayout.e2e.spec.js
Outdated
Show resolved
Hide resolved
…lacer function for stringify
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…eterminative row addition check to test
| // Wait for some data to populate | ||
| // eslint-disable-next-line playwright/no-wait-for-timeout | ||
| await page.waitForTimeout(2000); // Wait for a few state changes | ||
|
|
There was a problem hiding this comment.
I think Playwright gone done this already - https://playwright.dev/docs/api/class-locatorassertions#locator-assertions-to-have-count
There was a problem hiding this comment.
well then... glad I did ALL THAT. Haha, let me switch this out and test to make sure.
There was a problem hiding this comment.
Actually, going back, I remember why I did this. The table is adding and removing rows basically at the same time, so I can't go by count, because the rows aren't being added. So what I'm doing here is observing added nodes to the table child list (tr's would count). I wait for 20 rows to be added, then I verify there are non-filtered rows shown and filtered rows NOT shown. Not the simplest way to go about it, but I'm open to options.
There was a problem hiding this comment.
I think I understand, you want to count 20 add events, not 20 total rows.
…rwriting each other (#7930) * initial implementation * cleaning up a bit * adding the hash method back as we dont want gigantic keys * adding a line * added filtering to state generator, updated filters readme to fix error, more robust hash function * removing unnecessary changes in wrong file * adding a test to confirm each endpoint has a separate subscription based of filtering * lint * adding back in hints, accidentally removed * remove some redundant code and convert sanitization method into a replacer function for stringify * tweaking serialize replacer to handle arrays correctly, adding more determinative row addition check to test * more focused selector for the table * simplified the serialization method even further and added some more docs
Closes #7933
Describe your changes:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist