Merge pull request #1320 from nasa/integration-candidate

osal Integration candidate: Caelum-rc4+dev27
nasa · Oct 26, 2022 · 4567e8b · 4567e8b
2 parents fa9671f + c79db7a
commit 4567e8b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # Changelog
 
-## Development Build: v6.0.0-rc4:dev143
+## Development Build: v6.0.0-rc4+dev147
+- adjust timing on condvar tests
+- See <https://github.com/nasa/osal/pull/1319>
+
+## Development Build: v6.0.0-rc4+dev143
 - locks for condvar objects on rtems/vxworks
 - Add time conversion reciprocal functions
 - add export targets and package script

diff --git a/src/os/inc/osapi-version.h b/src/os/inc/osapi-version.h
@@ -34,7 +34,7 @@
 /*
  * Development Build Macro Definitions
  */
-#define OS_BUILD_NUMBER   143
+#define OS_BUILD_NUMBER   147
 #define OS_BUILD_BASELINE "v6.0.0-rc4"
 
 /*

diff --git a/src/tests/condvar-test/condvar-test.c b/src/tests/condvar-test/condvar-test.c
@@ -90,7 +90,7 @@ void condvar_worker(uint32 my_num)
         ++my_state->run_count;
         UtPrintf("Doing Work task %u, mask=0x%x condition was=%x\n", (unsigned int)my_num, (unsigned int)my_state->mask,
                  (unsigned int)prev_condition);
-        OS_TaskDelay(50 + (NUM_TASKS * 5));
+        OS_TaskDelay(25 + (NUM_TASKS * 5));
     }
 }
 
@@ -169,7 +169,6 @@ void CondVarTest_Execute(void)
         UtAssert_UINT32_EQ(total_work, num_signals);
         UtAssert_UINT32_NEQ(curr_condition, ALL_RUN_CONDITION);
         UtAssert_UINT32_NEQ(curr_condition, 0);
-        UtAssert_UINT32_EQ(task_states[i].run_count, 1);
         UtAssert_INT32_EQ(OS_CondVarUnlock(condvar_id), OS_SUCCESS);
 
         UtAssert_INT32_EQ(OS_CondVarSignal(condvar_id), OS_SUCCESS);
@@ -180,13 +179,19 @@ void CondVarTest_Execute(void)
 
     /* after a the last signal, all the other tasks should have run */
     UtAssert_INT32_EQ(OS_CondVarLock(condvar_id), OS_SUCCESS);
+    for (i = 0; i < NUM_TASKS; ++i)
+    {
+        UtAssert_UINT32_EQ(task_states[i].run_count, 1);
+    }
     UtAssert_UINT32_EQ(total_work, num_signals);
     UtAssert_BITMASK_UNSET(curr_condition, ALL_RUN_CONDITION);
     curr_condition = ALL_RUN_CONDITION;
     UtAssert_INT32_EQ(OS_CondVarBroadcast(condvar_id), OS_SUCCESS);
     UtAssert_INT32_EQ(OS_CondVarUnlock(condvar_id), OS_SUCCESS);
 
-    OS_TaskDelay(100);
+    /* Give sufficient time for all tasks to wake up and do their work */
+    OS_TaskDelay(100 + (NUM_TASKS * 10));
+
     UtAssert_INT32_EQ(OS_CondVarLock(condvar_id), OS_SUCCESS);
     UtAssert_BITMASK_UNSET(curr_condition, ALL_RUN_CONDITION);
     for (i = 0; i < NUM_TASKS; ++i)
@@ -198,7 +203,8 @@ void CondVarTest_Execute(void)
     UtAssert_INT32_EQ(OS_CondVarBroadcast(condvar_id), OS_SUCCESS);
     UtAssert_INT32_EQ(OS_CondVarUnlock(condvar_id), OS_SUCCESS);
 
-    OS_TaskDelay(20);
+    /* Give sufficient time for all tasks to wake up and do their work */
+    OS_TaskDelay(100 + (NUM_TASKS * 10));
 
     UtAssert_INT32_EQ(OS_CondVarLock(condvar_id), OS_SUCCESS);
     UtAssert_UINT32_EQ(total_work, (NUM_TASKS * 2) + 1);