You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently the UT_BSP_DoText used by UtAssert appends a newline after every message, see here:
Describe the solution you'd like
The append of the newline in UT_BSP_DoText() should only happen if the message did not have a trailing newline already. This will still accomplish the intent of making sure output messages end in a newline and do not run together, but will clean up extra unintended blank lines in the log files.
Additional context
This is mainly just a nitpick/pet peeve about the extra blank lines that come with "UtPrintf", but it also does potentially impact parsing log files with scripts.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Currently the
UT_BSP_DoText
used by UtAssert appends a newline after every message, see here:osal/ut_assert/src/utbsp.c
Line 184 in 706f0de
However, in many calls to
UtPrintf()
the test author already included a\n
in the format string, such as here:osal/src/unit-tests/oscore-test/ut_oscore_task_test.c
Line 85 in 706f0de
As a result there is extra whitespace in the log, example here:
https://gist.github.com/jphickey/ccb739d1f1cf6b36caca73e5ee9205cf#file-osal_core_ut-log-L391
Describe the solution you'd like
The append of the newline in
UT_BSP_DoText()
should only happen if the message did not have a trailing newline already. This will still accomplish the intent of making sure output messages end in a newline and do not run together, but will clean up extra unintended blank lines in the log files.Additional context
This is mainly just a nitpick/pet peeve about the extra blank lines that come with "UtPrintf", but it also does potentially impact parsing log files with scripts.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: