Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light coding standards cleanup #1380

Open
2 tasks done
thnkslprpt opened this issue Apr 14, 2023 · 0 comments · May be fixed by #1381
Open
2 tasks done

Light coding standards cleanup #1380

thnkslprpt opened this issue Apr 14, 2023 · 0 comments · May be fixed by #1381

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Some of the items listed in #933 could be cleared up without any changes to the code (i.e. easy wins):

  • split up multiple declarations on a single line
  • remove redundant definitions (i.e. values that are not used before the variable is assigned a new value)
  • remove side-effects from statements where no refactoring or new variables are needed
  • add braces to single line if/else blocks

Expected behavior
Comply with rules common to the relevant coding standards/guidelines where it makes sense, improves clarity, improves consistency and eases future maintenance.

Reporter Info
Avi Weiss @thnkslprpt

thnkslprpt added a commit to thnkslprpt/osal that referenced this issue Apr 14, 2023
@thnkslprpt thnkslprpt linked a pull request Apr 14, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants