Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS_FileSysAddFixedMap should use the virtual vs physical path name #1433

Closed
dmknutsen opened this issue Dec 7, 2023 · 0 comments · Fixed by #1448
Closed

OS_FileSysAddFixedMap should use the virtual vs physical path name #1433

dmknutsen opened this issue Dec 7, 2023 · 0 comments · Fixed by #1448
Assignees
@jphickey

Comments

@dmknutsen
Copy link
Contributor

Describe the bug
Submitting on behalf of a Gateway user:

Preface:
There are 2 drives with similar physical paths folder structures. We need to create a mapping to both shorten the path and abstract the Module DRIVE name.
i.e.
/DRIVE1/strm/gpfs -> /GW_D1
/DRIVE2/strm/gpfs -> /GW_D2

The problem is that OSAL OS_FileSysAddFixedMap needs to create a unique id ref string for the mapping. It seems to be just grabbing the sub-folder name of the physical path to create the unique id ref string.
i.e.
/DRIVE1/strm/gpfs
/DRIVE2/strm/gpfs

However, since both drives have the same sub-folder name it cannot create the second mapping.

OSAL OS_FileSysAddFixedMap should be using the new virtual path name given as the unique id string since those should always be unique.

i.e.
GW_D1
GW_D2

Reporter Info
Dan Knutsen
NASA Goddard
@dmknutsen dmknutsen changed the title OSAL OS_FileSysAddFixedMap should use the virtual vs physical path name OS_FileSysAddFixedMap should use the virtual vs physical path name Dec 7, 2023
jphickey added a commit to jphickey/osal that referenced this issue Feb 14, 2024
@jphickey
Fix nasa#1433, use virtual path as name for FS_BASED maps
d09682e 
Use the "virtual_path" instead of "device_name" as the name
record for FS_BASED entries.  This should allow duplicate
detection to work as expected.

The device_name on mappings made via this method will now be
an empty string.  It is not relevant because this type of map
is used for devices that are already mounted.
jphickey added a commit to jphickey/osal that referenced this issue Feb 14, 2024
@jphickey
Fix nasa#1433, use virtual path as name for FS_BASED maps
56ba9a9 
Use the "virtual_path" instead of "device_name" as the name
record for FS_BASED entries.  This should allow duplicate
detection to work as expected.

The device_name on mappings made via this method will now be
an empty string.  It is not relevant because this type of map
is used for devices that are already mounted.
@jphickey jphickey mentioned this issue Feb 14, 2024
Merged
2 tasks
jphickey added a commit to jphickey/osal that referenced this issue Feb 14, 2024
@jphickey
Fix nasa#1433, use virtual path as name for FS_BASED maps
47b2e41 
Use the "virtual_path" instead of "device_name" as the name
record for FS_BASED entries.  This should allow duplicate
detection to work as expected.

The device_name on mappings made via this method will now be
an empty string.  It is not relevant because this type of map
is used for devices that are already mounted.
dzbaker added a commit that referenced this issue Feb 22, 2024
@dzbaker
Merge pull request #1448 from jphickey:fix-1433-fixedmap
04149d8 
Fix #1433, use virtual path as name for FS_BASED maps
@dzbaker dzbaker mentioned this issue Feb 22, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1433, use virtual path as name for FS_BASED maps jphickey/osal
2 participants
@jphickey @dmknutsen