Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSAL Select APIs missing functional test #377

Closed
skliper opened this issue Mar 23, 2020 · 5 comments · Fixed by #683 or #690
Closed

OSAL Select APIs missing functional test #377

skliper opened this issue Mar 23, 2020 · 5 comments · Fixed by #683 or #690
Assignees
@zanzaben
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 23, 2020

Is your feature request related to a problem? Please describe.
OS_SelectMultipe, OS_SelectSingle, OS_SelectFdZero, OS_SelectFdAdd, OS_SelectFdClear, OS_SelectFdIsSet all missing functional tests

Describe the solution you'd like
Add tests

Describe alternatives you've considered
None

Additional context
Certification issue.

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 5.1.0 milestone Mar 23, 2020
@CDKnightNASA CDKnightNASA self-assigned this Mar 26, 2020
@CDKnightNASA
Copy link
Contributor

I'll start taking a crack at this.

This was referenced Mar 26, 2020
Closed
Closed
CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Mar 26, 2020
@CDKnightNASA
fix for nasa#377
0185088
@CDKnightNASA CDKnightNASA mentioned this issue Mar 26, 2020
Closed
CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Mar 26, 2020
@CDKnightNASA
fix for nasa#377 - adds unit tests for select api
9f1a486
@CDKnightNASA CDKnightNASA added unit-test Tickets related to the OSAL unit testing (functional and/or coverage) CCB:PendingCLA External contribution pending CLA confirmation CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) and removed CCB:PendingCLA External contribution pending CLA confirmation labels Mar 27, 2020
@astrogeco astrogeco added CCB - 20200401 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 1, 2020
@astrogeco astrogeco linked a pull request Apr 1, 2020 that will close this issue
adds unit tests for OS_Select... API #395
Closed
@CDKnightNASA
Copy link
Contributor

will wait for #405 to be merged into master and will use new macros, plus need to rebase and remerge the code from #391 and #392

CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Apr 7, 2020
@CDKnightNASA
fix nasa#377 - select UT
7c512ec
CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Apr 7, 2020
@CDKnightNASA
fix nasa#377 - select unit tests
634727c
@CDKnightNASA CDKnightNASA mentioned this issue Apr 7, 2020
Merged
@skliper skliper removed a link to a pull request Apr 9, 2020
adds unit tests for OS_Select... API #395
Closed
astrogeco pushed a commit that referenced this issue May 1, 2020
@CDKnightNASA
fix #377, fix #390, fix #392 - osal select API unit tests and fixes
e4b3789
@skliper
Copy link
Contributor Author

skliper commented May 13, 2020

This was closed by mistake, Select APIs still need a test to show they function correctly

@skliper skliper reopened this May 13, 2020
@jphickey
Copy link
Contributor

FYI - there IS now some unit test code which calls "select" ....

I have to make a change in the select API anyway to fix a different bug (#453), and change I'm making for that issue also requires some updates to these test cases. This is actually how the bug was noticed -- running this test on RTEMS caused failure.

@jphickey jphickey mentioned this issue May 14, 2020
Closed
@skliper skliper modified the milestones: 5.1.0, 5.2.0 Jun 5, 2020
@skliper
Copy link
Contributor Author

skliper commented Aug 11, 2020

TODO - check if #462 is sufficient to satisfy the unit test standards.

@skliper skliper modified the milestones: 5.2.0, 6.0.0 Sep 1, 2020
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 4, 2020
@zanzaben
fix nasa#377 Add Single Select Test
1b43a63
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 7, 2020
@zanzaben
fix nasa#377 add select read tests
3e229f0
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 7, 2020
@zanzaben
fix nasa#377 add select read tests
500cab2
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 10, 2020
@zanzaben
fix nasa#377 add select write test
5ad8b0e
@zanzaben zanzaben mentioned this issue Dec 10, 2020
Merged
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 15, 2020
@zanzaben
fix nasa#377 fix requested changes
d0f3120
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 15, 2020
@zanzaben
fix nasa#377 fix requested changes
b18e9d3
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 15, 2020
@zanzaben
fix nasa#377 fix race condition
d15206b
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 16, 2020
@zanzaben
fix nasa#377 fix race condition
1b85700
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 16, 2020
@zanzaben
fix nasa#377 fix requested changes
87b8915 
Update error warning
Close client sockets
Fix formating
define globals
zanzaben added a commit to zanzaben/osal that referenced this issue Dec 16, 2020
@zanzaben
Fix nasa#377 Add "OSAL Select" functional tests
d5727f9
astrogeco added a commit that referenced this issue Dec 18, 2020
@astrogeco
Merge pull request #683 from zanzaben/fix377_Select_Functional_Tests
3705934 
Fix #377, Add "OSAL Select" functional tests
@astrogeco astrogeco mentioned this issue Dec 18, 2020
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#377, Remove device driver requirements
8e69e05
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#377, Order requirements by ID
e72fd76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
6 participants
@zanzaben @jphickey @CDKnightNASA @skliper @astrogeco @yammajamma