Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS_SocketOpen UT stub returns "socket ID" not status #522

Closed
CDKnightNASA opened this issue Jun 23, 2020 · 0 comments · Fixed by #523 or #529
Closed

OS_SocketOpen UT stub returns "socket ID" not status #522

CDKnightNASA opened this issue Jun 23, 2020 · 0 comments · Fixed by #523 or #529
Assignees
@CDKnightNASA
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Bootes

Comments

@CDKnightNASA
Copy link
Contributor

Per the OS_SocketOpen() definition, on successful socket creation, it should set the sock_id out parameter and return status. Instead the stub does not set the sock_id but returns the ID.

osal/src/ut-stubs/osapi-utstub-sockets.c

Line 40 in bc73437

status = UT_AllocStubObjId(UT_OBJTYPE_SOCKET);

@CDKnightNASA CDKnightNASA added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Jun 23, 2020
@CDKnightNASA CDKnightNASA self-assigned this Jun 23, 2020
CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Jun 23, 2020
@CDKnightNASA
fix nasa#522 - SocketOpen stub should set sock_id
67c1890
@CDKnightNASA CDKnightNASA mentioned this issue Jun 23, 2020
Merged
@CDKnightNASA CDKnightNASA linked a pull request Jun 23, 2020 that will close this issue
Fix #522 - SocketOpen stub should set sock_id #523
Merged
astrogeco added a commit that referenced this issue Jul 1, 2020
@astrogeco
Merge pull request #523 from CDKnightNASA/fix-522-socketopen_stub
57701da 
Fix #522 - SocketOpen stub should set sock_id
@astrogeco astrogeco mentioned this issue Jul 1, 2020
Merged
@astrogeco astrogeco added this to the v5.1.0 milestone Sep 21, 2020
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#522, SB Requirements Scrub
528d16b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CDKnightNASA CDKnightNASA

Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Bootes
2 participants
@CDKnightNASA @astrogeco