Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect install/staging location for coverage test binaries #538

Closed
jphickey opened this issue Jul 9, 2020 · 0 comments · Fixed by #539 or #529
Closed

Incorrect install/staging location for coverage test binaries #538

jphickey opened this issue Jul 9, 2020 · 0 comments · Fixed by #539 or #529
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

jphickey commented Jul 9, 2020

Describe the bug
Typo in cmake file - the loop variable when installing coverage binaries is TGT but the DESTINATION refers to TGTNAME.

To Reproduce
Build with multiple CPUs sharing the same target+platform config.

Expected behavior
Binaries should be installed for everything in INSTALL_TARGET_LIST.

Code snips

foreach(TGT ${INSTALL_TARGET_LIST})
install(TARGETS ${TESTNAME}-testrunner DESTINATION ${TGTNAME}/${UT_INSTALL_SUBDIR})
endforeach()

System observed on:
Ubuntu 20.04

Additional context
The CFE scripts also do set TGTNAME in other places so it by chance had a leftover value that happened to be the same thing, and therefore this wouldn't be noticed when building for a single target (the default case).

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

jphickey added a commit to jphickey/osal that referenced this issue Jul 9, 2020
Should use the loop variable (TGT) not TGTNAME.
@jphickey jphickey self-assigned this Jul 9, 2020
@jphickey jphickey added the bug label Jul 9, 2020
astrogeco added a commit that referenced this issue Jul 15, 2020
Fix #538, correct loop variable for coverage install
@astrogeco astrogeco added this to the v5.1.0 milestone Sep 21, 2020
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants