Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Const correctness on input parameters #854

Closed
skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #894 or #917
Closed

Const correctness on input parameters #854

skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #894 or #917
Assignees
@skliper
Labels
CFS-38 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 10, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Missing const for a few parameters.

OSAL_set:

osal/src/os/portable/os-impl-bsd-select.c

Line 75 in ead5723

static int OS_FdSet_ConvertIn_Impl(fd_set *os_set, OS_FdSet *OSAL_set)

final_id (need to confirm):

osal/src/os/shared/src/osapi-idmap.c

Line 1106 in ead5723

void OS_ObjectIdTransactionFinish(OS_object_token_t *token, osal_id_t *final_id)

Describe the solution you'd like
Add const

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review
@skliper skliper added this to the 6.0.0 milestone Mar 10, 2021
@skliper skliper changed the title Const correctness in APIs Const correctness on input parameters Mar 10, 2021
@skliper skliper self-assigned this Mar 11, 2021
skliper added a commit to skliper/osal that referenced this issue Mar 11, 2021
@skliper
Fix nasa#854, Const correct input pointers
d414c62
@skliper skliper mentioned this issue Mar 11, 2021
Merged
@astrogeco astrogeco mentioned this issue Mar 17, 2021
Merged
astrogeco added a commit that referenced this issue Mar 17, 2021
@astrogeco
Merge pull request #894 from skliper/fix854-const_correct
8d6638d 
Fix #854, Const correct input pointers
@jphickey jphickey mentioned this issue Jun 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
CFS-38 enhancement
Projects
None yet
Milestone
Caelum
1 participant
@skliper