Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationale for select right after connect (or remove) #862

Closed
skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #909 or #917
Closed

Rationale for select right after connect (or remove) #862

skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #909 or #917
Assignees
@jphickey
Labels
CFS-38 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 10, 2021

Is your feature request related to a problem? Please describe.
Rationale for select() right after connect()? If the socket is selectable, then it wasn't made non-blocking. (see line 162) connect blocks until the connection is made or an error occurs.

osal/src/os/portable/os-impl-bsd-sockets.c

Line 283 in ead5723

return_code = OS_SelectSingle_Impl(token, &operation, timeout);

Describe the solution you'd like
Justify (add comment) or remove.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review
@skliper skliper added this to the 6.0.0 milestone Mar 10, 2021
jphickey added a commit to jphickey/osal that referenced this issue Mar 15, 2021
@jphickey
Fix nasa#862, comments describing select after connect
ef94a3d 
A select() is used after connect() to provide application-controlled
timeout on the connection initiation.

This just adds some comments to describe why this is done.  It also
adds a debug statement if the connect fails for a reason other than
EINPROGRESS.
@jphickey jphickey mentioned this issue Mar 15, 2021
Merged
@astrogeco astrogeco mentioned this issue Mar 19, 2021
Merged
astrogeco added a commit that referenced this issue Mar 19, 2021
@astrogeco
Merge pull request #909 from jphickey/fix-862-socket-connect-select
6f033be 
Fix #862, comments describing select after connect
astrogeco added a commit to astrogeco/osal that referenced this issue Mar 22, 2021
@astrogeco
Merge pull request nasa#909 from jphickey/fix-862-socket-connect-select
4725184 
Fix nasa#862, comments describing select after connect
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@CDKnightNASA
fix nasa#862 - unsub of a message ID that is already unsubbed should …
be1a23a 
…now work as expected
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@yammajamma
Merge pull request nasa#865 from CDKnightNASA/fix-862-unsub_of_unsubd
fd85c70 
fix nasa#862 - unsub of a message ID that is already unsubbed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
CFS-38 enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper