Fix #1141, add typecast to memchr call #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is documented as returning `void*`, and on some compilers this requires an explicit cast to `const char*` to avoid a warning.
|
After further consideration, I think the reason this warning got tripped is because the function in question is an inline, and in the proposed code change it was possibly included from a C++ source file. A void conversion like this is valid in C but in C++ requires a cast. Nonetheless, this makes the headers C++ compliant so still a valid thing to add. |
skliper
approved these changes
Sep 7, 2021
astrogeco
added
the
CCB:Ready
|
Do we want to do a "co-authored by" credit? |
Doesn't matter to me. Don't make more work than necessary. |
astrogeco
removed
the
CCB:Ready
|
CCB:2021-09-08 APPROVED |
astrogeco
added
the
CCB:Approved
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 8, 2021
nasa/osal#1142, Add typecast to memchr call
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 8, 2021
nasa/osal#1144, Regex update in coverage enforcement to match .0 nasa/osal#1142, Add typecast to memchr call
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 10, 2021
**Combines** nasa/cFE#1939, v6.8.0-rc1+dev994 nasa/osal#1145, v5.1.0-rc1+dev604 nasa/PSP#307, v1.5.0-rc1+dev124 nasa/sch_lab#87, v2.4.0-rc1+dev47 **Includes** *cFE* nasa/cFE#1903, Update directory diagrams in application developer guide nasa/cFE#1922, SB code coverage improvements #1905, Improve SB coverage nasa/cFE#1936, Improve ES code coverage nasa/cFE#1938, Enforce minimum code coverage nasa/cFE#1940, Update dev guide for MSG and SBR nasa/cFE#1941, Support unimplemented features in MSG FT *osal* nasa/osal#1144, Regex update in coverage enforcement to match .0 nasa/osal#1142, Add typecast to memchr call *psp* nasa/PSP#307, check that module type is not invalid nasa/PSP#306, do not override add_psp_module for coverage test *sch_lab* nasa/sch_lab#86, add CmdCode to sch_lab_table nasa/sch_lab#88, Fix missing typedef Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#1141, pipe name unset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This function is documented as returning
void*, and on some compilers this requires an explicit cast toconst char*to avoid a warning.Fixes #1141
Testing performed
Build and sanity check CFE
Expected behavior changes
None
System(s) tested on
Ubuntu
Additional context
Isolated from draft contribution from @thesamprice in #1140
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.