Fix #1324, Fix #1325, cppcheck updates #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes a cmake configuration so cppcheck can use the exported commands, allowing it to use all header files that the actual build uses.
jphickey
changed the title
dzbaker
approved these changes
Nov 17, 2022
dzbaker
added
CCB:Ready
Resolves a number of issues reported by cppcheck.
jphickey
force-pushed
the
fix-1324-cppcheck
branch
from
e39ce73
to
ff110cc
Compare
|
Force pushed just to get github to re-run the "PR title format check" ... |
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 17, 2022
*Combines:* osal v6.0.0-rc4+devtbd **Includes:** *cFS* - #598 - #611 *osal* - nasa/osal#1335 - nasa/osal#1329 - nasa/osal#1336 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com> Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 17, 2022
*Combines:* osal v6.0.0-rc4+dev161 **Includes:** *cFS* - #598 - #611 *osal* - nasa/osal#1335 - nasa/osal#1329 - nasa/osal#1336 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com> Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
dzbaker
added
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Passes a cmake configuration so cppcheck can use the exported commands, allowing it to use all header files that the actual build uses.
Also Resolves a number of other issues reported by cppcheck
Fixes #1324
Fixes #1325
Testing performed
Build and run tests
Verify results of static analysis workflow
Expected behavior changes
Static analysis workflow should be clean
System(s) tested on
Github workflow
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.