Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1366, removed cast that hid bug at compile time #1367

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

pepepr08
Copy link
Contributor

@pepepr08 pepepr08 commented Feb 14, 2023

Checklist (Please check before submitting)

Describe the contribution
Fix #1366

System(s) tested on

  • Hardware: GR740
  • OS: RTEMS
  • Versions: cFS draco-rc2 + mods

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Jose F. Martinez Pedraza | GSFC 582

@jphickey
Copy link
Contributor

Definitely think we should merge this, looking back it seems the previous change fixed only the actual underlying issue - which was that the functions were incompatible - by adding a wrapper, but the cast itself wasn't removed. Good idea to remove the cast, too, which should reduce the risk that a similar issue gets re-introduced somehow.

@pepepr08 pepepr08 added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 14, 2023
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Feb 16, 2023
@dzbaker dzbaker merged commit adf88ee into nasa:main Feb 16, 2023
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB Equuleus-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cast when starting timebase callback
4 participants