Fix #1365, fixup API headers for C++ #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct a few syntactical items that are valid C99 but not valid for C++03. This includes use of the designated initializer, compound literals, variadic macros, and a trailing comma in enum declarations. Note this only matters for public API headers, as some users may need to include these directly from a c++ file. For normal C source files, these are all compiled as C99 and thus the syntax is fine.
dzbaker
added
the
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Mar 2, 2023
*Combines:* osal v6.0.0-rc4+dev205 **Includes:** *osal* - nasa/osal#1371 - nasa/osal#1372 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This was referenced Mar 2, 2023
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Mar 2, 2023
*Combines:* osal v6.0.0-rc4+dev205 **Includes:** *osal* - nasa/osal#1371 - nasa/osal#1372 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Correct a few syntactical items that are valid C99 but not valid for C++03. This includes use of the designated initializer, compound literals, variadic macros, and a trailing comma in enum declarations.
Note this only matters for public API headers, as some users may need to include these directly from a c++ file. For normal C source files, these are all compiled as C99 and thus the syntax is fine.
Fixes #1365
Testing performed
Build and run all OSAL tests
Expected behavior changes
No impact to behavior, headers are now valid syntax for C++03 (and C99, of course)
System(s) tested on
Debian (using g++ 12.2 to check C++ syntax)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.