Fix #1382, Create Workflow for IC Bundle Generation #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbaker
force-pushed
the
icbundleworkflow
branch
from
c80f5f7
to
eeae362
Compare
…pushing them to the integration-candidate branch.
dzbaker
force-pushed
the
icbundleworkflow
branch
from
eeae362
to
55a9f70
Compare
jphickey
requested changes
Apr 20, 2023
There was a problem hiding this comment.
Similar comments as in nasa/cFE#2298 ... can we have a different name for every IC?
I'd also point out from some experience that long blocks in workflows can get confusing if something fails. If the blocks can be split into smaller chunks, I'd recommend that.
|
CCB 20 April 2023: Configure shell to trigger BASH to exit if something goes wrong in run block. Split run blocks where possible. |
dzbaker
added
CCB:Provisionally-Approved
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 25, 2023
*Combines:* cFE v7.0.0-rc4+dev276 osal v6.0.0-rc4+dev213 PSP v1.6.0-rc4+dev76 **Includes:** *cFE* - nasa/cFE#2299 - nasa/cFE#2300 - nasa/cFE#2298 *osal* - nasa/osal#1383 *PSP* - nasa/PSP#391 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Dylan Z. Baker <dzbaker@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 25, 2023
*Combines:* cFE v7.0.0-rc4+dev276 osal v6.0.0-rc4+dev213 PSP v1.6.0-rc4+dev76 **Includes:** *cFE* - nasa/cFE#2299 - nasa/cFE#2300 - nasa/cFE#2298 *osal* - nasa/osal#1383 *PSP* - nasa/PSP#391 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Dylan Z. Baker <dzbaker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Testing performed
Generated IC branch in fork.
Expected behavior changes
Adds new workflow for integration candidate branch generation.
Contributor Info - All information REQUIRED for consideration of pull request
Dylan Z. Baker/NASA GSFC 582