Fix #593, change OCS_off_t to a signed type #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C library type is signed, and this makes the result check work as intended.
jphickey
added
the
CCB:Ready
Closed
|
CCB 2020-09-09 APPROVED |
yammajamma
added
IC-20200909
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
The C library type is signed, and this makes the result check work as intended.
Fixes #593
Testing performed
Run all unit tests.
Note OCS_off_t is only used in coverage testing for OSAL.
Expected behavior changes
Fixes issue if caller uses correct type
off_tto store result.System(s) tested on
Ubuntu 20.04
Additional context
Issue was exposed by Travis CI failure in change suggested in PR #592, but really a separate issue.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.