Fix #542, Avoid UT failure if SEM_VALUE_MAX >= UINT32_MAX #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
force-pushed
the
fix542-semvaluemax_wrap
branch
from
3ef419d
to
9a73cb5
Compare
skliper
added
the
CCB:Ready
astrogeco
added
CCB-20201216
and removed
CCB:Ready
|
CCB 2020-12-16 APPROVED
|
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 18, 2020
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#681, Resolve doxygen warnings for tbl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #542 - avoids a potential unit test failure if an invalid semaphore value can not be passed in
Testing performed
Build and run unit tests, passed
Expected behavior changes
None.
System(s) tested on
Additional context
Unable to reproduce error from issue (requires feedback from @mbenson1) but this fix avoids a potential error case.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC