Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in aep8 #73

Closed
jacobwilliams opened this issue Feb 4, 2024 · 2 comments · Fixed by #74
Closed

Bug in aep8 #73

jacobwilliams opened this issue Feb 4, 2024 · 2 comments · Fixed by #74

Comments

@jacobwilliams
Copy link

radbelt/radbelt/core.f

Line 50 in 75fbf40

IF (IER .NE. 0) STOP

This IER in AEP8 should be IERR. IER is never given a value, so it can be anything.
@lpsinger
Copy link
Contributor

lpsinger commented Feb 9, 2024

I'm not much of a FORTRAN programmer. Is it also a problem that IERR is not defined?

lpsinger added a commit to lpsinger/radbelt that referenced this issue Feb 9, 2024
@lpsinger
Fix typo: IER -> IERR
3dee8c8 
Fixes nasa#73.
@lpsinger lpsinger mentioned this issue Feb 9, 2024
Merged
lpsinger added a commit that referenced this issue Feb 9, 2024
@lpsinger
Fix typo: IER -> IERR
1060924 
Fixes #73.
@jacobwilliams
Copy link
Author

IERR was an integer (since the Fortran implicit typing rules are in effect since this function doesn't have implicit none), and given a value by the OPEN call, so that was fine. It doesn't hurt to explicitly define it as you have done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo: IER -> IERR lpsinger/radbelt
2 participants
@lpsinger @jacobwilliams