Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol name cleanup and remainder of pattern/convention fixes #210

Closed
jphickey opened this issue Nov 1, 2023 · 0 comments · Fixed by #212
Closed

Symbol name cleanup and remainder of pattern/convention fixes #210

jphickey opened this issue Nov 1, 2023 · 0 comments · Fixed by #212
Assignees
Labels
enhancement New feature or request

Comments

@jphickey
Copy link
Contributor

jphickey commented Nov 1, 2023

Is your feature request related to a problem? Please describe.
There are still a few symbol names in sample_app that do not (quite) adhere to the conventions, and some further source file organization changes.

Examples -
SampleAppTable vs. SAMPLE_APP_Table_t - Type name vs. Table name mismatched.
Command processor functions should end in Cmd suffix
There should be separate "dispatch" file for the TaskPipe function, that switches based on received msgID and CC.

Describe the solution you'd like
Rename symbols, organize source functions.

Also - The unit test should be split into units per source file - this is a preferred approach for larger apps, so SAMPLE_APP should use this template, even though it is simple and thus not strictly necessary

Additional context
This should bring sample_app fully into compliance

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Nov 1, 2023
@jphickey jphickey added the enhancement New feature or request label Nov 1, 2023
dzbaker added a commit that referenced this issue Nov 13, 2023
Fix #210, Fix #211, bring sample_app fully into compliance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant