Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMPLE_ReportHousekeeping fails, likely due to nasa/cfe#674 #64

Closed
skliper opened this issue May 11, 2020 · 5 comments · Fixed by #63
Closed

SAMPLE_ReportHousekeeping fails, likely due to nasa/cfe#674 #64

skliper opened this issue May 11, 2020 · 5 comments · Fixed by #63
Assignees
Labels
bug Something isn't working
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented May 11, 2020

Describe the bug
UT failure, likely related to nasa/cFE#674:

[BEGIN] 05 SAMPLE_ReportHousekeeping
[ FAIL] 05.001 coveragetest_sample_app.c:391 - HkTelemetryMsg.Payload.CommandCounter (0) == 22
[ FAIL] 05.002 coveragetest_sample_app.c:395 - HkTelemetryMsg.Payload.CommandErrorCounter (0) == 11
[ PASS] 05.003 coveragetest_sample_app.c:401 - CFE_TBL_Manage() called
[  END] 05 SAMPLE_ReportHousekeeping TOTAL::3     PASS::1     FAIL::2      MIR::0      TSF::0      N/A::0

To Reproduce
Build and run unit tests at bundle level with nasa/cFE#674 included

Expected behavior
Tests pass

Code snips
N/A

System observed on:

Additional context
N/A

Reporter Info
Jacob Hageman - NASA/GSFC

@skliper skliper added the bug Something isn't working label May 11, 2020
@skliper skliper added this to the 1.2.0 milestone May 11, 2020
@skliper
Copy link
Contributor Author

skliper commented May 11, 2020

@jphickey could you take this one, planning to fasttrack. Either that or back out nasa/cFE#674 from this round (assuming it's the culprit) .

@jphickey
Copy link
Contributor

Found this is due to the pkt length being 0 so the output packet isn't being copied out.
In here we need to call CFE_SB_InitMsg() and in the SB stub side we need to fix the reading of the length.

@jphickey
Copy link
Contributor

Should I put this in a PR or go direct to IC?

jphickey added a commit that referenced this issue May 11, 2020
The FSW code relies on the message being pre-initalized which
needs to be done explicitly in unit test code.
@jphickey
Copy link
Contributor

Nevermind - I just pushed direct to IC as a hotfix as you mentioned you wanted to fasttrack. See commit 155a3e7

@jphickey jphickey self-assigned this May 11, 2020
@jphickey
Copy link
Contributor

See also nasa/cFE@6f06b16 for the CFE side of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants