String checks in UT should check only the spec/format string, not the fully rendered text. #97
Comments
jphickey
added a commit
that referenced
this issue
Sep 17, 2020
The fully-rendered strings are not entirely consistent, affected by many external factors outside the control of the test cases. There was even a warning in the comment against doing this, but it was included nonetheless as an example of how it can be done. This now keeps the original example but keeps it in the comment only, and converts the actual test to follow the recommended practice of only testing the spec/format string, not the fully-rendered string. This should be much more stable going forward, and should work with both CCSDS v1 and v2 configs.
|
Note #94 does not break v1 when merged with nasa/cFE#880. |
yammajamma
added a commit
that referenced
this issue
Sep 21, 2020
Fix #97, check only format string in UT event test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
As the comment in the code suggests, the "fully-rendered" text is really a derived output that depends on a lot of external factors. It isn't a direct output of the unit under test.
As an example, the unit test is currently getting thrashed around due to a message ID check due to the fact that there is no specific text that is always "correct" here.
It broke when updated to 32 bit (#87), attempted to fix in #94, which only broke the original case (v1 header).
To Reproduce
Run unit test using v1 (16-bit) message IDs.
Currently failing in the integration-candidate branch
Expected behavior
Tests should pass.
System observed on:
Ubuntu 20.04 and Travis-CI (current integration candidate).
Additional context
Recommendation is to only check the SPEC STRING (
0x%x) which will be the same regardless of what the "invalid msgid" value actually is. That's all that really matters.Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: