Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #135, update cmake recipe #136

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Apr 6, 2023

Describe the contribution
Prefer target-scope properties over directory scope where applicable

Fixes #135

Testing performed
Build and run tests, sanity check

Expected behavior changes
No impact

System(s) tested on
Debian

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Prefer target-scope properties over directory scope where applicable
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 6, 2023
@dzbaker dzbaker added CCB:Approved and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 6, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 10, 2023
*Combines:*

PSP v1.6.0-rc4+dev71
ci_lab v2.5.0-rc4+dev43
sample_app v1.3.0-rc4+dev39
sch_lab v2.5.0-rc4+dev49
to_lab v2.5.0-rc4+dev41

**Includes:**

*PSP*
- nasa/PSP#389

*ci_lab*
- nasa/ci_lab#136

*sample_app*
- nasa/sample_app#203

*sch_lab*
- nasa/sch_lab#136

*to_lab*
- nasa/to_lab#150

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Apr 10, 2023
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 12, 2023
*Combines:*

PSP v1.6.0-rc4+dev71
ci_lab v2.5.0-rc4+dev43
sample_app v1.3.0-rc4+dev39
sch_lab v2.5.0-rc4+dev49
to_lab v2.5.0-rc4+dev41

**Includes:**

*PSP*
- nasa/PSP#389

*ci_lab*
- nasa/ci_lab#136

*sample_app*
- nasa/sample_app#203

*sch_lab*
- nasa/sch_lab#136

*to_lab*
- nasa/to_lab#150

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@dzbaker dzbaker merged commit 161dd27 into nasa:main Apr 12, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 12, 2023
*Combines:*

PSP v1.6.0-rc4+dev71
ci_lab v2.5.0-rc4+dev43
sample_app v1.3.0-rc4+dev39
sch_lab v2.5.0-rc4+dev49
to_lab v2.5.0-rc4+dev41

**Includes:**

*PSP*
- nasa/PSP#389

*ci_lab*
- nasa/ci_lab#136

*sample_app*
- nasa/sample_app#203

*sch_lab*
- nasa/sch_lab#136

*to_lab*
- nasa/to_lab#150

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 13, 2023
*Combines:*

cFE v7.0.0-rc4+dev268
sch_lab v2.5.0-rc4+dev53
to_lab v2.5.0-rc4+dev45

**Includes:**

*cFE*
- nasa/cFE#2254
- nasa/cFE#2288
- nasa/cFE#2290

*sch_lab*
- nasa/sch_lab#136

*to_lab*
- nasa/to_lab#139

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Apr 13, 2023
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 13, 2023
*Combines:*

cFE v7.0.0-rc4+dev268
sch_lab v2.5.0-rc4+dev53
to_lab v2.5.0-rc4+dev45

**Includes:**

*cFE*
- nasa/cFE#2254
- nasa/cFE#2288
- nasa/cFE#2290

*sch_lab*
- nasa/sch_lab#136

*to_lab*
- nasa/to_lab#139

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@jphickey jphickey deleted the fix-135-cmake-recipe branch November 1, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cmake script to use current best practices
2 participants