Fix #34, Build fails with deprecated cFE/OSAL elements removed #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrogeco
changed the title
astrogeco
changed the title
astrogeco
added
the
CCB:Ready
jphickey
approved these changes
Feb 11, 2020
astrogeco
added
CCB:Ignore
astrogeco
suggested changes
Feb 12, 2020
There was a problem hiding this comment.
Please create an issue in sch_lab that mirrors nasa/sample_app#35 and link it to this PR
astrogeco
added
CCB:Ready
astrogeco
approved these changes
Feb 12, 2020
astrogeco
changed the title
|
CCB 20200212 - Approved |
1 similar comment
|
CCB 20200212 - Approved |
astrogeco
added
code reviewed
and removed
CCB:Ready
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #35, Build fails with deprecated cFE/OSAL elements removed
Testing performed
Nominal build process:
Confirmed clean build in both cases.
Expected behavior changes
Clean build when OMIT_DEPRECATED = true
System(s) tested on
Oracle VM VirtualBox
OS: ubuntu-18.04.3
Versions: cFE 6.7.5.0, OSAL 5.0.5.0, PSP 1.4.3.0
Additional context
There is a total of three pull requests to address issue_35:
nasa/to_lab
nasa/sample_app
nasa/sch_lab
All three are intended to be delivered together.
Contributor Info
Dan Knutsen
GSFC/NASA