Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #56, Apply alignment pattern #57

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Fix #56, Apply alignment pattern #57

merged 1 commit into from
Dec 8, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Nov 30, 2020

Describe the contribution
Fix #56

  • Use CFE_MSG_CommandHeader_t and CFE_MSG_TelemetryHeader_t in
    command and telemetry type definitions
  • Use CFE_SB_TransmitMsg to copy the command and telemetry
    into a CFE_SB_Buffer_t and send it where needed
  • Avoids need to create send buffers within the app (or union
    the packet types with CFE_SB_Buffer_t)
  • Eliminates references to CFE_SB_CmdHdr_t and CFE_SB_TlmHdr_t
    that formerly enforced alignment since these had potential
    to change the actual packet sizes

Testing performed
Bundle CI, unit tests, spot checked cmd/tlm

Expected behavior changes
None, pattern applied

System(s) tested on

Additional context
Depends on nasa/cFE#1015, #55

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 30, 2020
@astrogeco astrogeco added CCB-20201202 dependency conflict and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Dec 2, 2020
skliper added a commit to skliper/cFS that referenced this pull request Dec 3, 2020
@skliper
Bundle main + updates for alignment pattern
3899057 
- nasa/cFE#1015
- nasa/ci_lab#63
- nasa/sample_app#112
- nasa/sch_lab#57
- nasa/to_lab#69
skliper added a commit to skliper/cFS that referenced this pull request Dec 3, 2020
@skliper
Bundle main + updates for alignment pattern
fbfd230 
- nasa/cFE#1015
- nasa/ci_lab#63
- nasa/sample_app#112
- nasa/sch_lab#57
- nasa/to_lab#69
@astrogeco astrogeco changed the base branch from main to integration-candidate December 7, 2020 14:58
@astrogeco
Copy link
Contributor

@skliper, can you fix conflict?

@skliper
Fix nasa#56, Apply message alignment pattern
1b5ed8a 
- Use CFE_MSG_CommandHeader_t and CFE_MSG_TelemetryHeader_t in
  command and telemetry type definitions
- Use CFE_SB_TransmitMsg to copy the command and telemetry
  into a CFE_SB_Buffer_t and send it where needed
- Avoids need to create send buffers within the app (or union
  the packet types with CFE_SB_Buffer_t)
- Eliminates references to CFE_SB_CmdHdr_t and CFE_SB_TlmHdr_t
  that formerly enforced alignment since these had potential
  to change the actual packet sizes
@skliper
Copy link
Contributor Author

skliper commented Dec 8, 2020

@astrogeco fixed.

@astrogeco astrogeco removed the conflict label Dec 8, 2020
@astrogeco astrogeco merged commit 80fcb3a into nasa:integration-candidate Dec 8, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Dec 8, 2020
@astrogeco
Add nasa/sch_lab#57
56eb3be
astrogeco added a commit to nasa/cFS that referenced this pull request Dec 9, 2020
@astrogeco
Add nasa/sch_lab#57
031f624
@astrogeco astrogeco mentioned this pull request Dec 9, 2020
Merged
@skliper skliper deleted the fix56-alignment-pattern branch February 1, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update for suggested alignment enforcement pattern (nasa/cFE#1009)
2 participants
@skliper @astrogeco