Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #135, Add version information to NOOP event #136

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 22, 2022

Checklist

Describe the contribution

Testing performed
Run/Build and confirmed NOOP command event reporting as expected.
Screenshot 2022-10-22 21 00 58

Expected behavior changes
Adds version information to NOOP command to align with the other cFS components/apps.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-135-add-version-information-to-noop-event branch from 54a8227 to bbe42b2 Compare October 22, 2022 11:24
@dzbaker dzbaker added the CCB:Approved Indicates approval by CCB label Nov 3, 2022
@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to get these into the next round

@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 1, 2023
@thnkslprpt thnkslprpt force-pushed the fix-135-add-version-information-to-noop-event branch 3 times, most recently from 3181539 to e23416c Compare November 30, 2023 03:28
@dzbaker dzbaker removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 22, 2024
@dzbaker
Copy link
Contributor

dzbaker commented Feb 22, 2024

Hi @thnkslprpt, would you be able to update this to make use of CFE_Config_GetVersionString() (see line 207 of to_lab_app.c for an example)? Thanks!

@thnkslprpt thnkslprpt force-pushed the fix-135-add-version-information-to-noop-event branch from e23416c to 93342ef Compare February 23, 2024 09:12
@thnkslprpt thnkslprpt force-pushed the fix-135-add-version-information-to-noop-event branch from 93342ef to 23a5728 Compare February 23, 2024 09:19
@thnkslprpt
Copy link
Contributor Author

Hi @thnkslprpt, would you be able to update this to make use of CFE_Config_GetVersionString() (see line 207 of to_lab_app.c for an example)? Thanks!

@dzbaker That's updated now Dylan.

@dzbaker
Copy link
Contributor

dzbaker commented Feb 23, 2024

Hi @thnkslprpt, would you be able to update this to make use of CFE_Config_GetVersionString() (see line 207 of to_lab_app.c for an example)? Thanks!

@dzbaker That's updated now Dylan.

Excellent, thanks!

dzbaker added a commit that referenced this pull request Feb 23, 2024
…on-to-noop-event

Fix #135, Add version information to NOOP event
dzbaker added a commit to nasa/cFS that referenced this pull request Feb 23, 2024
*Combines:*

cFE equuleus-rc1+dev96
osal equuleus-rc1+dev53
to_lab equuleus-rc1+dev44

**Includes:**

*cFE*
- nasa/cFE#2515
- nasa/cFE#2330

*osal*
- nasa/osal#1448
- nasa/osal#1146
- nasa/osal#1357
- nasa/osal#1354
- nasa/osal#1331

*to_lab*
- nasa/to_lab#191
- nasa/to_lab#136

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Sam Price <thesamprice@users.noreply.github.com>
@dzbaker dzbaker merged commit 26ad97d into nasa:main Feb 23, 2024
11 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Feb 23, 2024
*Combines:*

cFE equuleus-rc1+dev96
osal equuleus-rc1+dev53
to_lab equuleus-rc1+dev44

**Includes:**

*cFE*
- nasa/cFE#2515
- nasa/cFE#2330

*osal*
- nasa/osal#1448
- nasa/osal#1146
- nasa/osal#1357
- nasa/osal#1354
- nasa/osal#1331

*to_lab*
- nasa/to_lab#191
- nasa/to_lab#136

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Sam Price <thesamprice@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report version when responding to NoOp Comand to match Sample App template
3 participants