Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #71, Remove all only from telemetry pipe #74

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Dec 14, 2020

Describe the contribution
Fix #71 - updated remove all to only remove Tlm_pipe subscriptions

Remove all was also removing subscriptions
from the command pipe, which leaves TO
inoperable. The remove all command now
just removes all subscriptions to the Tlm_pipe

Testing performed
Native build, sent remove all subscriptions cmd and confirmed, sent to noop multiple times and confirmed receipt

Expected behavior changes
TO remains commandable after a remove all subscriptions command

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
TO should mark empty slots with invalid MSGID, and not try to unsubscribe them - #72
TO should remove PktSize from packet add command (unused) - #73
GroundSystem add packet command definition needs update (Stream -> MsgId, should accept hex msgid, fix contents since they don't map correctly) - nasa/cFS-GroundSystem#141

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

Remove all was also removing subscriptions
from the command pipe, which leaves TO
inoperable.  The remove all command now
just removes all subscriptions to the Tlm_pipe
@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Dec 14, 2020
@skliper skliper added this to the 2.5.0 milestone Dec 14, 2020
@astrogeco astrogeco added CCB-20201216 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Dec 16, 2020
@astrogeco
Copy link
Contributor

astrogeco commented Dec 16, 2020

CCB 2020-12-16 APPROVED

Spawned some new issues

Brings up the question: are we "fully testing" the lab apps?

@astrogeco astrogeco changed the base branch from main to integration-candidate December 18, 2020 14:25
@astrogeco astrogeco merged commit 2d6f854 into nasa:integration-candidate Dec 18, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Dec 18, 2020
@skliper skliper deleted the fix71-rm_all_packets branch February 1, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove All Packet command causes to_lab to break
2 participants