fix type of Device.GroupName to string from bool #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ありがとうございます。コメントからも分かるように、nameなのにboolean、変だな〜って思いながら書きました。 |
nasa9084
approved these changes
Jul 18, 2023
|
報告してmergeされました～ OpenWonderLabs/SwitchBotAPI#225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
日本語で失礼します。
SwitchBot スマートロックを2つ買ってグループ化(ツインロックに)したのですが、デバイス一覧をとると
Device.GroupNameはstringで返されてきました。boolなのはDevice.Groupで、これがtrueの場合にGroupNameが現れます。go-switchbotではDevice.GroupNameがboolで記述されているため(公式ドキュメントが間違ってますね)Unmarshalで失敗してしまいますので、このPRでは単純にstringに書き換えます。(テストないですね)