Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support well typed variadic functions #130

Open
nasser opened this issue May 8, 2020 · 0 comments
Open

Support well typed variadic functions #130

nasser opened this issue May 8, 2020 · 0 comments
Assignees
@nasser
Labels
optimization

Comments

@nasser
Copy link
Owner

nasser commented May 8, 2020

All variadic function invocation currently happens through IFn, which will drop the types of any hinted required arguments. Ideally our generic Magic.Function interfaces would support the variadtic case as well as the fixed arity cases. The contents of & rest will almost certainly always be Object, though.
@nasser nasser self-assigned this May 8, 2020
nasser added a commit that referenced this issue May 8, 2020
@nasser
Support variadic functions
0f71da4 
Also changed the name of the invoke method exposed by the
Magic.Function interfaces from invoke to invokeTyped to avoid ambiguous
method matches in some cases. Variadic functions are always called
through IFn currently. Optimizing that is tracked in #130.

Fixes #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nasser nasser

Labels
optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nasser