Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track FieldBuilder volatility #191

Open
nasser opened this issue Jul 28, 2020 · 0 comments
Open

Track FieldBuilder volatility #191

nasser opened this issue Jul 28, 2020 · 0 comments
Labels
bug

Comments

@nasser
Copy link
Owner

nasser commented Jul 28, 2020

Due to a limitation in System.Reflection.Emit we cannot call GetRequiredCustomModifiers on FieldBuilders. We need this to know if a FieldBuilder is volatile or not. We were doing our own bookkeeping to keep track of this, but a recent change has rolled that back. We might want to look into a more generic strategy to get around System.Refection.Emit limitations, because this keeps coming up...
@nasser nasser added the bug label Jul 28, 2020
nasser added a commit that referenced this issue Jul 28, 2020
@nasser
Refactor instance field compilation
5be1b52 
Avoids deftype/closure problems but will not emit volatile. anymore.
Tracked in #191.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nasser