Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Criteria table from datastack archive produced by HRA doesn't work #1065

Closed
phargogh opened this issue Aug 26, 2022 · 1 comment · Fixed by #1477
Closed

Criteria table from datastack archive produced by HRA doesn't work #1065

phargogh opened this issue Aug 26, 2022 · 1 comment · Fixed by #1477
Assignees
@phargogh
Labels
bug Something isn't working in progress This issue is actively being worked on
Milestone
3.14.1

Comments

@phargogh
Copy link
Member

To reproduce:

  1. Open up the 3.12+ version of HRA (the one with the datastack override for spatial criteria)
  2. Load this datastack (Stanford auth required): https://drive.google.com/file/d/1tqheKjtekvNxavlB9FekCqtCycLIQZDX/view?usp=sharing
  3. Observe a validation error in the criteria table saying the table can't be opened as a CSV

The workaround for now is to:

  1. Extract the datastack somewhere
  2. Open the criteria table CSV in Excel
  3. Save the CSV to a new location as a CSV.
  4. Update the UI to use the new path
  5. The input validates as expected and the model runs.
@phargogh phargogh added the bug Something isn't working label Aug 26, 2022
@phargogh phargogh changed the title Loading a datastack produced by HRA doesn't work Criteria table from datastack archive produced by HRA doesn't work Aug 26, 2022
@phargogh phargogh added this to the 3.13.1 milestone Apr 7, 2023
@phargogh phargogh self-assigned this Apr 7, 2023
@phargogh phargogh modified the milestones: 3.14.0, 3.15.0 Sep 5, 2023
@dcdenu4 dcdenu4 modified the milestones: 3.15.0, 3.14.1 Oct 26, 2023
@phargogh phargogh added the in progress This issue is actively being worked on label Dec 13, 2023
phargogh added a commit to phargogh/invest that referenced this issue Dec 13, 2023
@phargogh
Converting path separators if on POSIX systems.
3e74b60 
RE:natcap#1065
@phargogh
Copy link
Member Author

It turns out that this isn't an issue with the criteria table any longer, but there was an issue with the info table w/r/t filepaths and mixed path separators. I'm about to submit a PR for that fix, which will close this issue.

@phargogh phargogh mentioned this issue Dec 13, 2023
Merged
1 task
phargogh added a commit to phargogh/invest that referenced this issue Dec 13, 2023
@phargogh
Correcting a test that implicitly uses utils.expand_path.
bac618d 
RE:natcap#1065
phargogh added a commit to phargogh/invest that referenced this issue Dec 14, 2023
@phargogh
Correcting function call and comment. RE:natcap#1065
0aa37ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
bug Something isn't working in progress This issue is actively being worked on
Projects
None yet
Milestone
3.14.1
Development

Successfully merging a pull request may close this issue.

Converting path separators in expand_path if on a POSIX system phargogh/invest
2 participants
@dcdenu4 @phargogh