Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenic quality aborting during percentiles #1189

Closed
phargogh opened this issue Feb 18, 2023 · 3 comments
Closed

Scenic quality aborting during percentiles #1189

phargogh opened this issue Feb 18, 2023 · 3 comments
Assignees
@phargogh
Labels
bug Something isn't working on hold There's a reason we're not working on this yet

Comments

@phargogh
Copy link
Member

While working on a SQ forums support issue, it appears that the model is aborting (hard crash) during percentiles calculation. The error message near the end indicates that the issue is likely because the sort directory cannot be created:

2023-02-08 15:24:08,588 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._calculate_visual_quality(979) INFO Calculating visual quality
2023-02-08 15:24:08,591 (natcap.invest.scenic_quality.scenic_quality) scenic_quality._calculate_visual_quality(988) INFO Determining percentiles for vshed.tif
2023-02-08 15:24:08,599 (pygeoprocessing.geoprocessing) geoprocessing.raster_calculator(396) INFO starting stats_worker
2023-02-08 15:24:08,600 (pygeoprocessing.geoprocessing_core) threading.run(953) DEBUG stats worker PID: 14808
2023-02-08 15:24:08,600 (pygeoprocessing.geoprocessing) geoprocessing.raster_calculator(402) INFO started stats_worker <Thread(Thread-70 (stats_worker), started daemon 11560)>
2023-02-08 15:24:08,712 (pygeoprocessing.geoprocessing) geoprocessing.raster_calculator(482) INFO 100.0% complete
2023-02-08 15:24:08,712 (pygeoprocessing.geoprocessing) geoprocessing.raster_calculator(485) INFO Waiting for raster stats worker result.
2023-02-08 15:24:08,918 (pygeoprocessing.geoprocessing_core) scenic_quality._calculate_visual_quality(1009) WARNING couldn't make working_sort_directory: [WinError 183] 当文件已存在时，无法创建该文件。: 'D:/我的坚果云/博士毕业论文/data/生态系统服务/ScenicQuality/Result3\\intermediate\\visual_quality4k5w352v'
2023-02-08 15:24:08,923 (pygeoprocessing.geoprocessing_core) scenic_quality._calculate_visual_quality(1009) DEBUG sorting data to heap
(EOF)
@phargogh phargogh added bug Something isn't working in progress This issue is actively being worked on labels Feb 18, 2023
@phargogh phargogh self-assigned this Feb 18, 2023
phargogh added a commit to phargogh/invest that referenced this issue Feb 18, 2023
@phargogh
Attempting a fix and noting change in history.
d225698 
I believe the issue is that the percentiles function requires that the
directory is empty (so it can delete it later) or does not yet exist (so
that it can create it and then delete it later). The directory passed to
the percentiles function was not empty.  This is now fixed by passing in
a directory that does not yet exist, within the existing temp directory
used by the rest of the function.

RE:natcap#1189
@phargogh phargogh added this to the 3.13.1 milestone Apr 7, 2023
@phargogh
Copy link
Member Author

phargogh commented Apr 14, 2023 •
edited
Loading

Another user on the forums has reported this issue. I'm merging in the latest changes from main into my bugfix branch and am rebuilding.

The dev build (windows) for this is at https://storage.googleapis.com/natcap-dev-build-artifacts/invest/phargogh/3.13.0.post37%2Bg8cfab49d4/workbench/invest_3.13.0.post37%2Bg8cfab49d4_workbench_win32_x64.exe

@phargogh phargogh modified the milestones: 3.14.0, 3.15.0 Aug 24, 2023
@dcdenu4 dcdenu4 added on hold There's a reason we're not working on this yet and removed in progress This issue is actively being worked on labels Oct 26, 2023
@dcdenu4
Copy link
Member

dcdenu4 commented Oct 26, 2023

On hold since communication has been dropped with the user reporting this bug and it has not come up outside of that.

@dcdenu4 dcdenu4 removed this from the 3.15.0 milestone Oct 26, 2023
@phargogh
Copy link
Member Author

Looking back on this bug and that we haven't heard anything else about it or encountered it again in almost a full year, I think we should close this issue.

@phargogh phargogh closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
bug Something isn't working on hold There's a reason we're not working on this yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcdenu4 @phargogh