Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error message in SWY if an invalid soil group is found #1193

Closed
phargogh opened this issue Feb 20, 2023 · 0 comments · Fixed by #1194
Closed

Improve the error message in SWY if an invalid soil group is found #1193

phargogh opened this issue Feb 20, 2023 · 0 comments · Fixed by #1194
Assignees
@phargogh
Labels
bug Something isn't working in progress This issue is actively being worked on

Comments

@phargogh
Copy link
Member

A user on the forums encountered a KeyError when they provided a soil group pixel with a value of 6, which is outside the valid set of values: {1, 2, 3, 4}. This exception should be made more readable.
@phargogh phargogh added bug Something isn't working in progress This issue is actively being worked on labels Feb 20, 2023
@phargogh phargogh self-assigned this Feb 20, 2023
phargogh added a commit to phargogh/invest that referenced this issue Feb 20, 2023
@phargogh
Validating soil groups at runtime.
9e6ae63 
A human-readable exception is now raised if an invalid soil group is
found.

RE:natcap#1193
phargogh added a commit to phargogh/invest that referenced this issue Feb 20, 2023
@phargogh
Explicitly testing the ndoata value exclusion. RE:natcap#1193
b28db30
@phargogh phargogh mentioned this issue Feb 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
bug Something isn't working in progress This issue is actively being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error message for SWY when invalid soil group pixel found phargogh/invest
1 participant
@phargogh