Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenic Quality fieldnames are expected to be uppercase, but this is not documented #1276

Closed
phargogh opened this issue Apr 7, 2023 · 1 comment · Fixed by #1277
Closed

Scenic Quality fieldnames are expected to be uppercase, but this is not documented #1276

phargogh opened this issue Apr 7, 2023 · 1 comment · Fixed by #1277
Assignees
@phargogh
Labels
bug Something isn't working in progress This issue is actively being worked on
Milestone
3.14.0

Comments

@phargogh
Copy link
Member

phargogh commented Apr 7, 2023

A user on the forum wrote to me in a DM:

i found the issue (but it is not clear in the documentation), the columns radius weight height in the csv are required to be in uppercase. and the distance for RADIUS requires to be in negative numbers

It'd be worth verifying this and seeing how the model's fieldnames and/or documentation can be improved.
@phargogh phargogh added bug Something isn't working in progress This issue is actively being worked on labels Apr 7, 2023
@phargogh phargogh added this to the 3.13.1 milestone Apr 7, 2023
@phargogh phargogh self-assigned this Apr 7, 2023
@phargogh
Copy link
Member Author

phargogh commented Apr 7, 2023

Well, it turns out that fields are required to be upper case, but I'm not so sure about the negative values ... the model calls math.fabs on the field values, so we should be fine there.

phargogh added a commit to phargogh/invest that referenced this issue Apr 7, 2023
@phargogh
SQ fieldnames are now more tolerant of spaces and case.
e3a06d8 
RE:natcap#1276
@phargogh phargogh mentioned this issue Apr 7, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
bug Something isn't working in progress This issue is actively being worked on
Projects
None yet
Milestone
3.14.0
Development

Successfully merging a pull request may close this issue.

Make SQ more tolerant of leading/trailing whitespace and case phargogh/invest
1 participant
@phargogh