-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HRA stressor comparison bug on sample data #1467
Comments
Interestingly, all tests pass so we must not be running a regression test on sample data. And looking at the HRA tests, all the unit tests use lowercase values for table creations. |
see also #1468 |
So, I think that reading the table with |
…ats. remove unnused constants.
…nd habitat case sensitivity.
A user on the forum noted they were getting an error when running HRA with sample data in 3.14.0.
https://community.naturalcapitalproject.org/t/error-in-hra-with-dawnloaded-sample-data/4339
It looks like when comparing stressors one table is lowercasing while the other is not. For the habitat_stressor_info table
validation.get_validated_dataframe
is being used which does return a table with lowercased values. For the criteria table,utils.read_csv_to_dataframe
is returning a table where values are NOT lowercased.Note:
validation.get_validated_dataframe
callsutils.read_csv_to_dataframe
, so this is likely an unique case handling the HRA criteria table.I can reproduce the issue with the latest
invest:main
The text was updated successfully, but these errors were encountered: