Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate GLOBIO #1138

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Deprecate GLOBIO #1138

merged 1 commit into from
Dec 20, 2022

Conversation

emlys
Copy link
Member

@emlys emlys commented Dec 19, 2022 •
edited
Loading

Description

Fixes #1131
Corresponding PRs:

Some tests are failing because the UG changes haven't been merged yet.

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the affected models' UIs (if relevant)

@emlys emlys changed the base branch from main to release/3.13.0 December 19, 2022 17:48
@emlys emlys self-assigned this Dec 19, 2022
@emlys emlys requested a review from davemfish December 19, 2022 17:53
@emlys emlys marked this pull request as ready for review December 19, 2022 21:22
davemfish
davemfish approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@davemfish davemfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I re-ran the Actions after merging the UG PR; builds are working. A couple unrelated Mac test failures on long Rec tests that timed out.

@davemfish davemfish merged commit b7ddd02 into natcap:release/3.13.0 Dec 20, 2022
@davemfish davemfish mentioned this pull request Jan 20, 2023
Closed
@dcdenu4 dcdenu4 mentioned this pull request Feb 27, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemfish davemfish davemfish approved these changes

Assignees

@emlys emlys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate GLOBIO
2 participants
@emlys @davemfish