Fix local documentation links #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a couple models that were pointing to the wrong html name.
…com/dcdenu4/invest into bugfix/319-local-docs-link-broken RE:natcap#319 Conflicts: HISTORY.rst
…local-docs-link-broken Merging the big sur branch into this one so that I can test it on my local dev computer. RE:natcap#319 Conflicts: HISTORY.rst
dcdenu4
approved these changes
Nov 24, 2020
|
Looks good to me! I downloaded the dmg, the license appears as expected, and the model documentation links are working. Since this is a superset of the changes in #392, I'll just copy my one minor comment over to here. |
emlys
reviewed
Nov 24, 2020
installer/darwin/dmgconf.py
Outdated
| @@ -31,4 +31,5 @@ def get_size(start_path = '.'): | |||
| #background = 'builtin-arrow' | |||
| default_view = 'icon-view' | |||
|
|
|||
|
|
|||
| format = 'UDZO' | |||
| license = {'licenses': {'en_US': 'LICENSE.txt'}} | |||
There was a problem hiding this comment.
Clearly it's not a serious issue, but the dmgbuild docs say that a 'default-language' key is also required in the license dictionary.
…local-docs-link-broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the broken documentation link issue by including @dcdenu4 's changes to the local paths defined in ARGS_SPEC objects, and also fixes the issue on Mac by including the documentation files within the
.appbundle (surprisingly, this actually works well, at least on Big Sur).Fixes #319
NOTE
I'm marking this as a draft for now until we can finish addressing #392
Checklist