Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user): user_info now displays when no experience #144

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

natelandau
Copy link
Owner

closes #143

@natelandau natelandau changed the title fix(user): fix bug where user_info would not display with no experience fix(user): user_info now displays when no experience Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.89%. Comparing base (468c4bb) to head (a48922d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   68.94%   68.89%   -0.05%     
==========================================
  Files          23       23              
  Lines        2315     2318       +3     
  Branches      383      383              
==========================================
+ Hits         1596     1597       +1     
- Misses        677      679       +2     
  Partials       42       42              
Files Coverage Δ
src/valentina/models/user.py 97.05% <50.00%> (-1.94%) ⬇️

@natelandau natelandau merged commit a71a4dd into main Jun 7, 2024
8 checks passed
@natelandau natelandau deleted the fix-user-info branch June 7, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can not view user info when no experience
1 participant