Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chargen): correctly create werewolves and changelings #186

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

natelandau
Copy link
Owner

No description provided.

@natelandau natelandau changed the title feat(chargen): Correctly create werewolves and changelings feat(chargen): correctly create werewolves and changelings Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 94.47236% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.96%. Comparing base (c95370b) to head (8c02724).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/valentina/constants.py 95.33% 6 Missing and 1 partial ⚠️
src/valentina/controllers/rng_chargen.py 91.30% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   71.89%   72.96%   +1.06%     
==========================================
  Files          61       61              
  Lines        3512     3617     +105     
  Branches      517      526       +9     
==========================================
+ Hits         2525     2639     +114     
+ Misses        896      887       -9     
  Partials       91       91              
Files with missing lines Coverage Δ
src/valentina/discord/characters/chargen.py 100.00% <ø> (ø)
src/valentina/models/character.py 83.54% <100.00%> (+0.10%) ⬆️
...ts/character_create/forms/character_create_full.py 78.72% <ø> (ø)
...ina/webui/blueprints/character_create/route_rng.py 31.48% <ø> (+4.49%) ⬆️
src/valentina/controllers/rng_chargen.py 92.49% <91.30%> (+1.45%) ⬆️
src/valentina/constants.py 97.74% <95.33%> (+0.39%) ⬆️

@natelandau natelandau merged commit bf8f62b into main Oct 19, 2024
7 of 11 checks passed
@natelandau natelandau deleted the develop branch October 19, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant