Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webui): roll dice from character pages #191

Merged
merged 3 commits into from
Oct 25, 2024
Merged

feat(webui): roll dice from character pages #191

merged 3 commits into from
Oct 25, 2024

Conversation

natelandau
Copy link
Owner

No description provided.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 81.18812% with 19 lines in your changes missing coverage. Please review.

Project coverage is 75.33%. Comparing base (3b2e788) to head (864bbf4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...valentina/webui/blueprints/diceroll_modal/route.py 79.16% 6 Missing and 4 partials ⚠️
...valentina/webui/blueprints/character_view/route.py 85.29% 3 Missing and 2 partials ⚠️
src/valentina/webui/utils/helpers.py 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   73.28%   75.33%   +2.05%     
==========================================
  Files          61       61              
  Lines        3728     3742      +14     
  Branches      442      440       -2     
==========================================
+ Hits         2732     2819      +87     
+ Misses        908      828      -80     
- Partials       88       95       +7     
Files with missing lines Coverage Δ
...ntina/webui/blueprints/diceroll_modal/blueprint.py 100.00% <100.00%> (ø)
src/valentina/webui/utils/helpers.py 50.00% <71.42%> (+20.50%) ⬆️
...valentina/webui/blueprints/character_view/route.py 79.74% <85.29%> (+4.36%) ⬆️
...valentina/webui/blueprints/diceroll_modal/route.py 71.59% <79.16%> (ø)

... and 5 files with indirect coverage changes

@natelandau natelandau merged commit df1c065 into main Oct 25, 2024
10 checks passed
@natelandau natelandau deleted the develop branch October 25, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant