Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webui): edit campaigns #194

Merged
merged 6 commits into from
Oct 29, 2024
Merged

feat(webui): edit campaigns #194

merged 6 commits into from
Oct 29, 2024

Conversation

natelandau
Copy link
Owner

No description provided.

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 35.76017% with 300 lines in your changes missing coverage. Please review.

Project coverage is 70.66%. Comparing base (87d43ac) to head (f1d0ac8).

Files with missing lines Patch % Lines
.../valentina/webui/blueprints/campaign_view/route.py 30.27% 146 Missing and 6 partials ⚠️
...tina/webui/blueprints/character_edit/route_info.py 16.07% 90 Missing and 4 partials ⚠️
src/valentina/discord/models/webui_hook.py 5.88% 48 Missing ⚠️
src/valentina/webui/utils/helpers.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   73.27%   70.66%   -2.61%     
==========================================
  Files          62       63       +1     
  Lines        3921     4224     +303     
  Branches      465      518      +53     
==========================================
+ Hits         2873     2985     +112     
- Misses        954     1139     +185     
- Partials       94      100       +6     
Files with missing lines Coverage Δ
src/valentina/constants.py 97.78% <100.00%> (+<0.01%) ⬆️
src/valentina/models/campaign.py 88.31% <100.00%> (+0.15%) ⬆️
...entina/webui/blueprints/campaign_view/blueprint.py 100.00% <100.00%> (ø)
.../valentina/webui/blueprints/campaign_view/forms.py 100.00% <100.00%> (ø)
...ntina/webui/blueprints/character_edit/blueprint.py 100.00% <100.00%> (ø)
...valentina/webui/blueprints/character_view/route.py 76.47% <100.00%> (-3.28%) ⬇️
src/valentina/webui/constants.py 100.00% <100.00%> (ø)
src/valentina/webui/utils/helpers.py 48.66% <33.33%> (-1.34%) ⬇️
src/valentina/discord/models/webui_hook.py 13.33% <5.88%> (-11.06%) ⬇️
...tina/webui/blueprints/character_edit/route_info.py 27.80% <16.07%> (+0.26%) ⬆️
... and 1 more

... and 2 files with indirect coverage changes

@natelandau natelandau changed the title refactor(webui): refactor character edit route feat(webui): edit campaign books and chapters Oct 28, 2024
@natelandau natelandau changed the title feat(webui): edit campaign books and chapters feat(webui): edit campaigns Oct 29, 2024
@natelandau natelandau merged commit 154cb21 into main Oct 29, 2024
6 of 9 checks passed
@natelandau natelandau deleted the develop branch October 29, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant