Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable nullable ref type checking #425

Merged
merged 6 commits into from
Jan 16, 2021
Merged

refactor: enable nullable ref type checking #425

merged 6 commits into from
Jan 16, 2021

Conversation

natemcmaster
Copy link
Owner

Prior to this, some nullability annotations were incorrect.

⚠️ This is technically a breaking change on a few public methods where ValidationResult! has been changed to ValidationResult?. The previous nullability annotation were incorrect. See the PublicAPI.Shipped.txt changes for a full list of impacted APIs.

@natemcmaster natemcmaster added this to the 4.0.0 milestone Jan 16, 2021
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #425 (d9d9994) into main (db2b121) will decrease coverage by 0.12%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
- Coverage   67.84%   67.72%   -0.13%     
==========================================
  Files         105      106       +1     
  Lines        3281     3284       +3     
==========================================
- Hits         2226     2224       -2     
- Misses       1055     1060       +5     
Impacted Files Coverage Δ
...mandLineUtils/CommandLineApplication.Validation.cs 95.74% <ø> (ø)
src/CommandLineUtils/CommandLineApplication{T}.cs 90.90% <ø> (ø)
...mandLineUtils/HelpText/DefaultHelpTextGenerator.cs 94.73% <ø> (ø)
...l/ValueParsers/TypeDescriptorValueParserFactory.cs 84.21% <ø> (ø)
.../CommandLineUtils/Properties/NullabilityHelpers.cs 0.00% <0.00%> (ø)
.../CommandLineUtils/Validation/AttributeValidator.cs 82.60% <ø> (ø)
...Utils/Attributes/FilePathNotExistsAttributeBase.cs 71.42% <50.00%> (ø)
...mandLineUtils/Attributes/AllowedValuesAttribute.cs 66.66% <100.00%> (ø)
...ineUtils/Attributes/FilePathExistsAttributeBase.cs 73.68% <100.00%> (ø)
...mandLineUtils/Attributes/LegalFilePathAttribute.cs 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2b121...d9d9994. Read the comment docs.

Base automatically changed from ns21 to main January 16, 2021 21:35
@natemcmaster natemcmaster merged commit e0b6a2c into main Jan 16, 2021
@natemcmaster natemcmaster deleted the cleanups branch January 16, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant